builder: delay free data structure to reduce image build time #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to perf flame graph, it takes a long time to free objects used by image builder. In most common cases, the builder will only run once and exit, so it's unnecessary to free those used objects. Signed-off-by: Jiang Liu <[email protected]>
jiangliu
requested review from
bergwolf,
liubin and
hsiangkao
and removed request for
a team
|
@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/74684 |
Codecov Report
@@ Coverage Diff @@
## master #1298 +/- ##
=======================================
Coverage 46.03% 46.03%
=======================================
Files 124 124
Lines 36934 36953 +19
Branches 36934 36953 +19
=======================================
+ Hits 17004 17013 +9
- Misses 19041 19052 +11
+ Partials 889 888 -1
|
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
liubogithub
approved these changes
May 25, 2023
|
@adamqqqplay , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/75278 |
|
@adamqqqplay , The CI test is completed, please check result:
Sorry, your test job failed. Please get the details in the link. |
||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to perf flame graph, it takes a long time to free objects used by image builder. In most common cases, the builder will only run once and exit, so it's unnecessary to free those used objects.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.