-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builder: delay free data structure to reduce image build time #1298
Conversation
According to perf flame graph, it takes a long time to free objects used by image builder. In most common cases, the builder will only run once and exit, so it's unnecessary to free those used objects. Signed-off-by: Jiang Liu <[email protected]>
@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/74684 |
Codecov Report
@@ Coverage Diff @@
## master #1298 +/- ##
=======================================
Coverage 46.03% 46.03%
=======================================
Files 124 124
Lines 36934 36953 +19
Branches 36934 36953 +19
=======================================
+ Hits 17004 17013 +9
- Misses 19041 19052 +11
+ Partials 889 888 -1
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
@adamqqqplay , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/75278 |
@adamqqqplay , The CI test is completed, please check result:
Sorry, your test job failed. Please get the details in the link. |
According to perf flame graph, it takes a long time to free objects used by image builder. In most common cases, the builder will only run once and exit, so it's unnecessary to free those used objects.
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.